Skip to content

Comments

London | 25-SDC-Nov | Emiliano Uruena | Sprint 5 | Prep Exercises#306

Open
Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Emilianouz:Sprint5
Open

London | 25-SDC-Nov | Emiliano Uruena | Sprint 5 | Prep Exercises#306
Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Emilianouz:Sprint5

Conversation

@Emilianouz
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all Sprint 5 prep exercises following the provided guide.
This includes: object-oriented programming concepts such as classes, inheritance, methods, dataclasses, enums, and generics.

Also worked through mypy type checking and type-guided refactoring to reinforce static typing and code quality.

@Emilianouz Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 5 Assigned during Week 5 of this module labels Dec 17, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 14, 2026
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work on these tasks, there are some areas where you could improve further

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe the difference and any dis/advantage of using a class method vs a function?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 14, 2026
Added error handling for age input and improved output formatting.
Updated print_family_tree to include indentation and level.
@Emilianouz Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 16, 2026
@LonMcGregor
Copy link

Good work, this is almost complete. One of the items mentioned in the prep task was to describe the differences between methods and functions. Could you briefly describe in a comment here what the main differences or advantages/disadvantages there are between these two ideas?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 16, 2026
@Emilianouz
Copy link
Author

Good work, this is almost complete. One of the items mentioned in the prep task was to describe the differences between methods and functions. Could you briefly describe in a comment here what the main differences or advantages/disadvantages there are between these two ideas?

methods are functions that belong to a class or object. and operates on the data contained within an object.

Functions are reusable since they do not rely on object states. Their use could be general in a project; but a Method belong to an object, keeping the data and the logic in one package.

@Emilianouz Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 16, 2026
@LonMcGregor
Copy link

Good answers. PR complete!

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 5 Assigned during Week 5 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants